Skip to content

Fix parameter constness differences in function declarations and definitions #2337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 18, 2018
Merged

Fix parameter constness differences in function declarations and definitions #2337

merged 1 commit into from
May 18, 2018

Conversation

akosthekiss
Copy link
Member

JerryScript-DCO-1.0-Signed-off-by: Akos Kiss [email protected]

@akosthekiss
Copy link
Member Author

Pointed out by MSVC on AppVeyor:

jerry-core\ecma\builtin-objects\ecma-builtin-array-prototype.c(129): warning C4028: formal parameter 1 different from declaration
jerry-core\ecma\builtin-objects\ecma-builtin-array-prototype.c(336): warning C4028: formal parameter 1 different from declaration
jerry-core\ecma\builtin-objects\ecma-builtin-array-prototype.c(336): warning C4028: formal parameter 2 different from declaration
jerry-core\lit\lit-strings.c(626): warning C4028: formal parameter 1 different from declaration

LaszloLango
LaszloLango approved these changes May 17, 2018
View reviewed changes
Copy link
Contributor

@LaszloLango LaszloLango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@yichoi
Copy link
Contributor

yichoi commented May 18, 2018

LGTM

@yichoi yichoi merged commit fb6259b into jerryscript-project:master May 18, 2018
@akosthekiss akosthekiss deleted the fix-const-params branch May 18, 2018 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LaszloLango LaszloLango LaszloLango approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@akosthekiss @yichoi @LaszloLango